Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated setup.py #24

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Updated setup.py #24

merged 3 commits into from
Apr 15, 2021

Conversation

iamansoni
Copy link
Contributor

Closes #19

Reused data from requirements.txt in install_requires of setup.py

Added requirements.txt to be read as a file in the setup.py and passed it as a list of strings to install_requires.
@iamansoni iamansoni requested a review from a team as a code owner April 13, 2021 15:01
@emmaindal
Copy link
Member

Thank you @iamansoni for contributing with this change. I can see the linter is not happy, if you can look into that it would be great and then also add a one-liner in the changelog as well as a version bump in setup.py and we are ready to merge this!

Addressed the issue of linter; and made a version bump.
@iamansoni iamansoni mentioned this pull request Apr 14, 2021
@iamansoni
Copy link
Contributor Author

I don't know why I'm still receiving the black lint issue; I've checked it on my local system and the code turns out to be working fine over there.

s1

Signed-off-by: Emma Indal <emmai@spotify.com>
@emmaindal
Copy link
Member

I don't know why I'm still receiving the black lint issue; I've checked it on my local system and the code turns out to be working fine over there.

s1

Seems like it was just a few spaces that caused the issue. I pushed an update so it should be ready to get merged. Thank you for the contribution 🎉

@emmaindal emmaindal merged commit 8535172 into backstage:main Apr 15, 2021
viccie30 added a commit to viccie30/mkdocs-techdocs-core that referenced this pull request Jun 22, 2023
PR backstage#24 deduplicated the requirements, but this makes the sdist on PyPi
fail to build, because requirements.txt is not included.

This fix includes requirements.txt using MANIFEST.in and changes the
publication workflow to use build instead of calling setup.py directly.
build always builds the wheel from the sdist, so this error is
prevented in the future.
@viccie30 viccie30 mentioned this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicated dependencies list
2 participants